Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore underscore after DISABLED in test name #4497

Merged
merged 1 commit into from
Mar 4, 2024
Merged

restore underscore after DISABLED in test name #4497

merged 1 commit into from
Mar 4, 2024

Conversation

grg
Copy link
Contributor

@grg grg commented Mar 3, 2024 •
edited
Loading

Restore the underscore after DISABLED to tell googletest that the test should be excluded.

I believe the underscore was accidentally deleted in #4381.

@grg
restore underscore after DISABLED in test name
5ac9429 
Restore the underscore after DISABLED to tell googletest that the test
should be excluded.
@grg grg requested a review from fruffy March 3, 2024 20:38
@grg grg marked this pull request as ready for review March 3, 2024 20:39
@grg grg added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit f02d57e Mar 4, 2024
17 checks passed
@grg grg deleted the grgibb/gtest_disabled_fix branch March 4, 2024 03:34
@fruffy fruffy added the core Topics concerning the core segments of the compiler (frontend, midend, parser) label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fruffy fruffy fruffy approved these changes

Assignees
No one assigned
Labels
core Topics concerning the core segments of the compiler (frontend, midend, parser)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grg @fruffy